You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/08/23 02:46:36 UTC
[PR] GH-43796: [C++] Indent #if (preprocessor directives) [arrow]
kou opened a new pull request, #43798:
URL: https://github.com/apache/arrow/pull/43798
### Rationale for this change
This is for easy to read.
### What changes are included in this PR?
* Add clang-format configurations for preprocessor directives indentation
* Apply these configurations
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent #if (preprocessor directives) [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2306082789
:warning: GitHub issue #43796 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2314633845
It makes sense. I've chanted the title as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2316458776
The discussion thread: https://lists.apache.org/thread/gb2dpphhwz358zfb03k9ly18gs92rzdr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2333068103
No objection in the discussion thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #43798:
URL: https://github.com/apache/arrow/pull/43798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2333986010
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5ad0b3e36f9302c4cf8dd5ab997f30bfab95e2d4.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/29782873976) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2314634282
(I'll fix the lint failure later.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43796: [C++] Indent preprocessor directives [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43798:
URL: https://github.com/apache/arrow/pull/43798#issuecomment-2333252011
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org