[jira] [Commented] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package

["Taher Alkhateeb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464751#comment-16464751 ] 

Taher Alkhateeb commented on OFBIZ-10344:
-----------------------------------------

On a first view of this commit it looks well thought out, thank you for your work.

The formatting needs some work though, the lines are too long. It is a common convention for java streams to be broken down to lines (usually at the dot operator). I also think some places where streams are used, the code looks worse not better. Streams are supposed to make the code easier to read, not harder. So it's a combination of proper formatting and making sure you use the right tool at the right place.

Also, some care needs to be taken into picking variable names. Using cryptic and short names makes things worse not better.

This is my feedback insofar, well done on the effort.

> Refactoring Variable Scope for org.apache.ofbiz.base package
> ------------------------------------------------------------
>
>                 Key: OFBIZ-10344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10344
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pradhan Yash Sharma
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10344.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)