[GitHub] [hudi] xushiyan commented on a diff in pull request #6040: [HUDI-4322] Deprecate partition value extractor

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #6040:
URL: https://github.com/apache/hudi/pull/6040#discussion_r917454294


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java:
##########
@@ -187,15 +204,6 @@ public <T> Double getDouble(ConfigProperty<T> configProperty) {
     return rawValue.map(v -> Double.parseDouble(v.toString())).orElse(null);
   }
 
-  public <T> String getStringOrDefault(ConfigProperty<T> configProperty) {
-    return getStringOrDefault(configProperty, configProperty.defaultValue().toString());
-  }
-
-  public <T> String getStringOrDefault(ConfigProperty<T> configProperty, String defaultVal) {
-    Option<Object> rawValue = getRawValue(configProperty);
-    return rawValue.map(Object::toString).orElse(defaultVal);
-  }

Review Comment:
   re-arranged `getString*()` methods to keep them close



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org