[jira] [Commented] (ARTEMIS-2092) First page messages lost on server crash

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620384#comment-16620384 ] 

ASF GitHub Bot commented on ARTEMIS-2092:
-----------------------------------------

GitHub user wy96f opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2324

    ARTEMIS-2092 fix first page messages lost on server crash bug

    Reproduction steps:
    
    1. Send messages(using non transactional session), ensure the queue enters page mode and only one page is created.
    2. Kill -9 server process or crash server.
    3. Start the server and we find that page created in step 1 is deleted. Messages in the page are lost.
    
    When server starts, we should set empty flag of pageSubscription to false if pendingCounter record is loaded to prevent cleanup process from deleting the page.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wy96f/activemq-artemis first_page_messages_lost

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2324
    
----
commit 3028969c049a5e9b4d2b772efa16920a6e6ccb90
Author: yang wei <wy...@...>
Date:   2018-09-19T09:42:02Z

    ARTEMIS-2092 fix first page messages lost on server crash bug

----


> First page messages lost on server crash
> ----------------------------------------
>
>                 Key: ARTEMIS-2092
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2092
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.6.3
>            Reporter: yangwei
>            Priority: Major
>
> Reproduction steps:
>  # Send messages(using non transactional session), ensure the queue enters page mode and only one page is created.
>  # Kill -9 server process or crash server.
>  # Start the server and we find that page created in step 1 is deleted. Messages in the page are lost.
> When server starts, we should set empty flag of pageSubscription to false if pendingCounter record is loaded to prevent cleanup process from deleting the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)