[GitHub] [guacamole-client] mike-jumper opened a new pull request #476: GUACAMOLE-883: Correct guacViewport and guacTextInput behavior on iOS 13.

[GitBox <gi...@apache.org>]

mike-jumper opened a new pull request #476: GUACAMOLE-883: Correct guacViewport and guacTextInput behavior on iOS 13.
URL: https://github.com/apache/guacamole-client/pull/476
 
 
   On iOS 13 / iPadOS 13, the `guacViewport` directive fails to function correctly due to the following:
   
   * `window.scrollTo()` is invoked with values beyond the allowed scroll range. This is not an error per se, and should result in the page scrolling to the limits of the scroll range, but in the case of iOS 13 this causes touch events to no longer register.
   * The `guacTextInput` directive refuses to lose focus. This also is not inherently an issue, but apparently causes trouble in iOS' handling of screen resize due to device rotation. Unless focus is allowed to be lost, iOS Safari incorrectly reports the size of the viewport following device rotation (it stops accounting for the size of the visible mobile keyboard), and will never correctly report it again unless text input is disabled and re-enabled.
   
   This change refactors `guacViewport` to rely on `window.innerWidth` and `window.innerHeight` to determine the viewport size rather than calculating the same using scroll coordinates/dimensions. The `guacTextInput` directive has also been modified to not attempt to keep focus, with the exception of focus loss due to clicks within other parts of `guacTextInput`. Focus is attempted to be gained upon initialization, but that's it.
   
   Correcting viewport/focus behavior as described above also happily resolves [GUACAMOLE-810](https://issues.apache.org/jira/browse/GUACAMOLE-810).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [guacamole-client] necouchman merged pull request #476: GUACAMOLE-883: Correct guacViewport and guacTextInput behavior on iOS 13.

[GitBox <gi...@apache.org>]

necouchman merged pull request #476: GUACAMOLE-883: Correct guacViewport and guacTextInput behavior on iOS 13.
URL: https://github.com/apache/guacamole-client/pull/476
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services