You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/11/11 10:33:44 UTC
[GitHub] [hive] pvary commented on a change in pull request #1658: HIVE-24340: Mark phase for proactive cache eviction
pvary commented on a change in pull request #1658:
URL: https://github.com/apache/hive/pull/1658#discussion_r521264216
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -150,6 +151,8 @@ private LlapIoImpl(Configuration conf) throws IOException {
LowLevelCachePolicy
realCachePolicy =
useLrfu ? new LowLevelLrfuCachePolicy(minAllocSize, totalMemorySize, conf) : new LowLevelFifoCachePolicy();
+ // TODO: if realCachePolicy is not something that supports proactive caching
Review comment:
nit: `TODO: if realCachePolicy is not something that supports proactive caching`
Maybe:
`TODO: if realCachePolicy is not something that supports proactive cache eviction`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org