[GitHub] dhatchayani commented on a change in pull request #3062: [CARBONDATA-3241] Refactor the requested scan columns and the projection columns

[GitBox <gi...@apache.org>]

dhatchayani commented on a change in pull request #3062: [CARBONDATA-3241] Refactor the requested scan columns and the projection columns
URL: https://github.com/apache/carbondata/pull/3062#discussion_r247391958
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
 ##########
 @@ -449,9 +455,10 @@ private[sql] class CarbonLateDecodeStrategy extends SparkStrategy {
       projectsAttr: Seq[Attribute],
       filterSet: AttributeSet,
       handledSet: AttributeSet,
-      newProjectList: Seq[Attribute]) = {
-    (projectsAttr.to[mutable.LinkedHashSet] ++ filterSet -- handledSet)
-      .map(relation.attributeMap).toSeq ++ newProjectList
+      newProjectList: Seq[Attribute],
+      updatedProjects: Seq[Expression]): (Seq[Attribute], Seq[Expression]) = {
 
 Review comment:
   we are using this refactored code. so we need  it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services