You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/20 09:08:42 UTC
Re: Review Request 64608: Reverted unintended edit to cpplint.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64608/
-----------------------------------------------------------
(Updated Feb. 20, 2018, 10:08 a.m.)
Review request for mesos, Gaojin CAO, Michael Park, and Jan Schlicht.
Repository: mesos
Description
-------
In 'bea8c3c9' we replaced '> >' with '>>' in C++ templates in a sweep
across the codebase. We also unintentionally modified a comment in
'cpplint.py' which was e.g., not reflected in its patch file and also
lead to no functional changes.
This patch reverts this modification to 'cpplint.py'.
Diffs
-----
support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
Diff: https://reviews.apache.org/r/64608/diff/1/
Testing
-------
`./support/mesos-style.py 3rdparty/stout/tests/none_tests.cpp`
Thanks,
Benjamin Bannier
Re: Review Request 64608: Reverted unintended edit to cpplint.py.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64608/#review197766
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Feb. 20, 2018, 10:08 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64608/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2018, 10:08 a.m.)
>
>
> Review request for mesos, Gaojin CAO, Michael Park, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In 'bea8c3c9' we replaced '> >' with '>>' in C++ templates in a sweep
> across the codebase. We also unintentionally modified a comment in
> 'cpplint.py' which was e.g., not reflected in its patch file and also
> lead to no functional changes.
>
> This patch reverts this modification to 'cpplint.py'.
>
>
> Diffs
> -----
>
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64608/diff/1/
>
>
> Testing
> -------
>
> `./support/mesos-style.py 3rdparty/stout/tests/none_tests.cpp`
>
>
> Thanks,
>
> Benjamin Bannier
>
>