You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/03 09:46:01 UTC

[GitHub] [ignite] sergeyuttsel opened a new pull request #7989: IGNITE-13210 changed the generated names of parameterized tests

sergeyuttsel opened a new pull request #7989:
URL: https://github.com/apache/ignite/pull/7989


   Parameterized tests in ServiceDeploymentProcessIdSelfTest class have constant name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] sergeyuttsel commented on a change in pull request #7989: IGNITE-13210 changed the generated names of parameterized tests

Posted by GitBox <gi...@apache.org>.
sergeyuttsel commented on a change in pull request #7989:
URL: https://github.com/apache/ignite/pull/7989#discussion_r469155936



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/service/ServiceDeploymentProcessIdSelfTest.java
##########
@@ -83,13 +87,17 @@ public ServiceDeploymentProcessIdSelfTest(IgniteBiTuple<DiscoveryEvent, Affinity
         customEvt.eventNode(node);
 
         return Arrays.asList(new Object[][] {
-            {new IgniteBiTuple<>(customEvt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))},
-            {new IgniteBiTuple<>(evt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))}});
+            {customEvt.getClass().getSimpleName(), new IgniteBiTuple<>(customEvt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))},
+            {evt.getClass().getSimpleName(), new IgniteBiTuple<>(evt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))}});
     }
 
     /** */
     @Test
     public void topologyVersion() {
+        System.out.println("test with event type: " + testLabel);

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] asfgit closed pull request #7989: IGNITE-13210 changed the generated names of parameterized tests

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #7989:
URL: https://github.com/apache/ignite/pull/7989


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alamar commented on a change in pull request #7989: IGNITE-13210 changed the generated names of parameterized tests

Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #7989:
URL: https://github.com/apache/ignite/pull/7989#discussion_r469145898



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/service/ServiceDeploymentProcessIdSelfTest.java
##########
@@ -83,13 +87,17 @@ public ServiceDeploymentProcessIdSelfTest(IgniteBiTuple<DiscoveryEvent, Affinity
         customEvt.eventNode(node);
 
         return Arrays.asList(new Object[][] {
-            {new IgniteBiTuple<>(customEvt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))},
-            {new IgniteBiTuple<>(evt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))}});
+            {customEvt.getClass().getSimpleName(), new IgniteBiTuple<>(customEvt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))},
+            {evt.getClass().getSimpleName(), new IgniteBiTuple<>(evt, new AffinityTopologyVersion(ThreadLocalRandom.current().nextLong()))}});
     }
 
     /** */
     @Test
     public void topologyVersion() {
+        System.out.println("test with event type: " + testLabel);

Review comment:
       Can we please log it instead of println?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org