[jira] [Commented] (KARAF-6182) Add override property to in feature

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848404#comment-16848404 ] 

ASF GitHub Bot commented on KARAF-6182:
---------------------------------------

jbonofre commented on pull request #852: [KARAF-6182] Add override attribute on feature config
URL: https://github.com/apache/karaf/pull/852
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add override property to <config/> in feature
> ---------------------------------------------
>
>                 Key: KARAF-6182
>                 URL: https://issues.apache.org/jira/browse/KARAF-6182
>             Project: Karaf
>          Issue Type: New Feature
>          Components: karaf
>    Affects Versions: 4.1.6
>            Reporter: Julien Greffe
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 4.3.0, 4.1.8, 4.2.6
>
>         Attachments: feature-test_init.xml, feature-test_updated_0.1.0.xml, feature-test_updated_0.2.0.xml
>
>
> Hello,
>  
> this issue is related to https://issues.apache.org/jira/browse/KARAF-2894, but seems it's still in OPEN state.
>  
>  
> Having this feature file (feature-test_init.xml), installing it and listing the config shows the right values :
> {{karaf@trun()> feature:install config-test}}
> {{karaf@trun()> config:list | grep configTest -A 5}}
> {{Pid: configTest.Default}}
> {{BundleLocation: null}}
> {{Properties:}}
> {{ myKey = "myInitValue"}}
> {{ org.apache.karaf.features.configKey = configTest.Default}}
> {{ service.pid = configTest.Default}}
>  
> Whenever removing the file from deploy dir, updating the feature file with new value + modified value (feature-test_updated_0.1.0.xml), installing again, the config shows old value + inserted value :
> {{karaf@trun()> feature:install config-test}}
> {{karaf@trun()> config:list | grep configTest -A 5}}
> {{Pid: configTest.Default}}
> {{BundleLocation: null}}
> {{Properties:}}
> {{ myKey = "myInitValue"}}
> {{ newKey = "someValue"}}
> {{ org.apache.karaf.features.configKey = configTest.Default}}
> {{ service.pid = configTest.Default}}
>  
> Changing the feature version (feature-test_updated_0.2.0.xml) doesn't update existing keys :
> {{karaf@trun()> feature:install config-test}}
> {{karaf@trun()> config:list | grep configTest -A 5}}
> {{Pid: configTest.Default}}
> {{BundleLocation: null}}
> {{Properties:}}
> {{ myKey = "myInitValue"}}
> {{ newKey = "someValue"}}
> {{ newKey2 = "someValue2"}}
> {{ org.apache.karaf.features.configKey = configTest.Default}}
> {{ service.pid = configTest.Default}}
>  
> In order to have updated values of existing keys, should I always have to execute {{config:delete <ID>}} ?
> Or is there an uninstall option which allows to also delete the related config?
> Is this related to [https://github.com/apache/karaf/blob/karaf-4.1.6/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java#L132] ?
>  
> Thank you,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)