You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ju...@apache.org on 2005/01/28 11:45:16 UTC
svn commit: r148874 - /geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Author: jules
Date: Fri Jan 28 02:45:14 2005
New Revision: 148874
URL: http://svn.apache.org/viewcvs?view=rev&rev=148874
Log:
give spring apps their own JMX domain - geronimo.spring
Modified:
geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Modified: geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Url: http://svn.apache.org/viewcvs/geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java?view=diff&rev=148874&p1=geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java&r1=148873&p2=geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java&r2=148874
==============================================================================
--- geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java (original)
+++ geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java Fri Jan 28 02:45:14 2005
@@ -151,8 +151,8 @@
for (int i=ids.length; i>0; i--)
dlbf.getBean(ids[i-1]);
- ObjectName name=new ObjectName("geronimo.config", "name", sprFile.getName());
- GBeanData gbeanData = new GBeanData(name, org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_INFO);
+ ObjectName name=new ObjectName("geronimo.spring", "name", sprFile.getName());
+ GBeanData gbeanData=new GBeanData(name, org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_INFO);
// setting 'kernel' results in a NotSerializableException: after
// returning from this method...
Re: svn commit: r148874 - /geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Posted by Jules Gosnell <ju...@coredevelopers.net>.
David,
we have a lot to think about :-) but how to map the deployable into the
gbean world is high on my list. I have to read code and do some
thinking. I'll get back to you for some more guidance on this and other
stuff in a little while.
Cheers,
Jules
David Jencks wrote:
> What would you think of giving spring gbeans jsr-77 like names? I've
> converted just about all the other gbeans to this format. I'm not
> sure if spring apps can be nested like jars, but how about something
> like
>
> geronimo.server:
> J2EEServer=geronimo,J2EEApplication=null,j2eeType=SpringModule,name=foo
>
> geronimo.server:
> J2EEServer=geronimo,J2EEApplication=null,SpringModule=foo,j2eeType=Sprin
> gBean,name=bar
>
> There's a lot of infrastructure now in NameFactory and Configuration
> to support this.
>
> thanks
> david jencks
>
> On Jan 28, 2005, at 2:45 AM, jules@apache.org wrote:
>
>> Author: jules
>> Date: Fri Jan 28 02:45:14 2005
>> New Revision: 148874
>>
>> URL: http://svn.apache.org/viewcvs?view=rev&rev=148874
>> Log:
>> give spring apps their own JMX domain - geronimo.spring
>>
>> Modified:
>>
>> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
>> spring/deployment/SPRConfigBuilder.java
>>
>> Modified:
>> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
>> spring/deployment/SPRConfigBuilder.java
>> Url:
>> http://svn.apache.org/viewcvs/geronimo/trunk/modules/spring-builder/
>> src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java?
>> view=diff&rev=148874&p1=geronimo/trunk/modules/spring-builder/src/
>> java/org/apache/geronimo/spring/deployment/
>> SPRConfigBuilder.java&r1=148873&p2=geronimo/trunk/modules/spring-
>> builder/src/java/org/apache/geronimo/spring/deployment/
>> SPRConfigBuilder.java&r2=148874
>> =======================================================================
>> =======
>> ---
>> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
>> spring/deployment/SPRConfigBuilder.java (original)
>> +++
>> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
>> spring/deployment/SPRConfigBuilder.java Fri Jan 28 02:45:14 2005
>> @@ -151,8 +151,8 @@
>> for (int i=ids.length; i>0; i--)
>> dlbf.getBean(ids[i-1]);
>>
>> - ObjectName name=new ObjectName("geronimo.config", "name",
>> sprFile.getName());
>> - GBeanData gbeanData = new GBeanData(name,
>> org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_IN
>> FO);
>> + ObjectName name=new ObjectName("geronimo.spring", "name",
>> sprFile.getName());
>> + GBeanData gbeanData=new GBeanData(name,
>> org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_IN
>> FO);
>>
>> // setting 'kernel' results in a NotSerializableException: after
>> // returning from this method...
>>
--
"Open Source is a self-assembling organism. You dangle a piece of
string into a super-saturated solution and a whole operating-system
crystallises out around it."
/**********************************
* Jules Gosnell
* Partner
* Core Developers Network (Europe)
*
* www.coredevelopers.net
*
* Open Source Training & Support.
**********************************/
Re: svn commit: r148874 - /geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Posted by David Jencks <da...@yahoo.com>.
What would you think of giving spring gbeans jsr-77 like names? I've
converted just about all the other gbeans to this format. I'm not sure
if spring apps can be nested like jars, but how about something like
geronimo.server:
J2EEServer=geronimo,J2EEApplication=null,j2eeType=SpringModule,name=foo
geronimo.server:
J2EEServer=geronimo,J2EEApplication=null,SpringModule=foo,j2eeType=Sprin
gBean,name=bar
There's a lot of infrastructure now in NameFactory and Configuration to
support this.
thanks
david jencks
On Jan 28, 2005, at 2:45 AM, jules@apache.org wrote:
> Author: jules
> Date: Fri Jan 28 02:45:14 2005
> New Revision: 148874
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=148874
> Log:
> give spring apps their own JMX domain - geronimo.spring
>
> Modified:
>
> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
> spring/deployment/SPRConfigBuilder.java
>
> Modified:
> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
> spring/deployment/SPRConfigBuilder.java
> Url:
> http://svn.apache.org/viewcvs/geronimo/trunk/modules/spring-builder/
> src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java?
> view=diff&rev=148874&p1=geronimo/trunk/modules/spring-builder/src/
> java/org/apache/geronimo/spring/deployment/
> SPRConfigBuilder.java&r1=148873&p2=geronimo/trunk/modules/spring-
> builder/src/java/org/apache/geronimo/spring/deployment/
> SPRConfigBuilder.java&r2=148874
> =======================================================================
> =======
> ---
> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
> spring/deployment/SPRConfigBuilder.java (original)
> +++
> geronimo/trunk/modules/spring-builder/src/java/org/apache/geronimo/
> spring/deployment/SPRConfigBuilder.java Fri Jan 28 02:45:14 2005
> @@ -151,8 +151,8 @@
> for (int i=ids.length; i>0; i--)
> dlbf.getBean(ids[i-1]);
>
> - ObjectName name=new ObjectName("geronimo.config", "name",
> sprFile.getName());
> - GBeanData gbeanData = new GBeanData(name,
> org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_IN
> FO);
> + ObjectName name=new ObjectName("geronimo.spring", "name",
> sprFile.getName());
> + GBeanData gbeanData=new GBeanData(name,
> org.apache.geronimo.j2ee.management.impl.SpringApplicationImpl.GBEAN_IN
> FO);
>
> // setting 'kernel' results in a NotSerializableException: after
> // returning from this method...
>