You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jimmytobin2425 (via GitHub)" <gi...@apache.org> on 2024/03/06 22:46:50 UTC
[PR] Jimmytobin2425 patch 1 [beam]
jimmytobin2425 opened a new pull request, #30550:
URL: https://github.com/apache/beam/pull/30550
The issue this warning message points to (https://github.com/apache/beam/issues/22969) has been resolved showing it was an issue with Python 2 and not with beam. I propose to remove this warning message to reduce log spam.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Jimmytobin2425 patch 1 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30550:
URL: https://github.com/apache/beam/pull/30550#issuecomment-1982330769
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @liferoad for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove warning message for mixing return and yield in DoFn [beam]
Posted by "jimmytobin2425 (via GitHub)" <gi...@apache.org>.
jimmytobin2425 commented on PR #30550:
URL: https://github.com/apache/beam/pull/30550#issuecomment-1984757752
Ah I think I misunderstood the resolution of the bug thread. Apologies. I'll close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove warning message for mixing return and yield in DoFn [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #30550:
URL: https://github.com/apache/beam/pull/30550#issuecomment-1984728437
This still causes the issues if you use Python 3. Not sure what you mean here.
This is why we have this https://beam.apache.org/documentation/programming-guide/#pardo:
<img width="991" alt="image" src="https://github.com/apache/beam/assets/7833268/384ef276-e4a7-414d-b133-5c58d73cc3ba">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove warning message for mixing return and yield in DoFn [beam]
Posted by "jimmytobin2425 (via GitHub)" <gi...@apache.org>.
jimmytobin2425 closed pull request #30550: Remove warning message for mixing return and yield in DoFn
URL: https://github.com/apache/beam/pull/30550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org