You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "oss-maker (via GitHub)" <gi...@apache.org> on 2023/07/06 05:31:29 UTC

[GitHub] [spark] oss-maker commented on a diff in pull request #41860: SPARK-44307 : Bloom filter is not added for left outer join if the left side table is smaller than broadcast threshold.

oss-maker commented on code in PR #41860:
URL: https://github.com/apache/spark/pull/41860#discussion_r1253951425


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -185,14 +186,18 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J
   }
 
   private def isProbablyShuffleJoin(left: LogicalPlan,
-      right: LogicalPlan, hint: JoinHint): Boolean = {
-    !hintToBroadcastLeft(hint) && !hintToBroadcastRight(hint) &&
-      !canBroadcastBySize(left, conf) && !canBroadcastBySize(right, conf)
+                                    right: LogicalPlan,
+                                    hint: JoinHint,
+                                    joinType: JoinType): Boolean = {

Review Comment:
   Could you please indent this better, use 4 spaces starting from the function definition for every parameter on new line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org