You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/13 09:33:01 UTC
[GitHub] [pulsar] Technoboy- opened a new issue #8049: Replace map with set
Technoboy- opened a new issue #8049:
URL: https://github.com/apache/pulsar/issues/8049
In PulsarClientImpl, we use IdentityHashMap to hold the reference of producers/consumers like below:
```
producers.put(producer, Boolean.TRUE);
```
It's better to use List, for value is never used but stored.
But Pulsar pursues performance, so looks good to use thread safe set -- Collections.newSetFromMap(new ConcurrentHashMap<>()) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed issue #8049: Replace map with set
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #8049:
URL: https://github.com/apache/pulsar/issues/8049
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org