You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:34:24 UTC

[GitHub] [arrow] pitrou commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

pitrou commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-626620567


   I see a slight slowdown here:
   * git master:
   ```
   -------------------------------------------------------------------------------------------
   Benchmark                                 Time             CPU   Iterations UserCounters...
   -------------------------------------------------------------------------------------------
   BM_ReadColumn<false,Int32Type>      3817689 ns      3814696 ns          733 bytes_per_second=10.24G/s
   BM_ReadColumn<true,Int32Type>      27211615 ns     27194320 ns           99 bytes_per_second=2.15463G/s
   BM_ReadColumn<false,Int64Type>      7085595 ns      7079927 ns          399 bytes_per_second=11.0347G/s
   BM_ReadColumn<true,Int64Type>      29967050 ns     29951421 ns           89 bytes_per_second=3.26049G/s
   BM_ReadColumn<false,DoubleType>     7098703 ns      7093371 ns          398 bytes_per_second=11.0138G/s
   BM_ReadColumn<true,DoubleType>     30548935 ns     30532825 ns           89 bytes_per_second=3.1984G/s
   BM_ReadColumn<false,BooleanType>   11931142 ns     11928150 ns          235 bytes_per_second=838.353M/s
   BM_ReadColumn<true,BooleanType>    29983466 ns     29970561 ns           92 bytes_per_second=1000.98M/s
   BM_ReadIndividualRowGroups         15547894 ns     15538074 ns          183 bytes_per_second=6.28497G/s
   BM_ReadMultipleRowGroups           15692019 ns     15682364 ns          182 bytes_per_second=6.22714G/s
   ```
   * this PR:
   ```
   -------------------------------------------------------------------------------------------
   Benchmark                                 Time             CPU   Iterations UserCounters...
   -------------------------------------------------------------------------------------------
   BM_ReadColumn<false,Int32Type>      3819328 ns      3816352 ns          740 bytes_per_second=10.2356G/s
   BM_ReadColumn<true,Int32Type>      30445380 ns     30429672 ns           89 bytes_per_second=1.92555G/s
   BM_ReadColumn<false,Int64Type>      7134237 ns      7128926 ns          397 bytes_per_second=10.9589G/s
   BM_ReadColumn<true,Int64Type>      35230806 ns     35215688 ns           81 bytes_per_second=2.77309G/s
   BM_ReadColumn<false,DoubleType>     7007725 ns      7001947 ns          394 bytes_per_second=11.1576G/s
   BM_ReadColumn<true,DoubleType>     33062963 ns     33046208 ns           83 bytes_per_second=2.95514G/s
   BM_ReadColumn<false,BooleanType>   12116716 ns     12113217 ns          232 bytes_per_second=825.545M/s
   BM_ReadColumn<true,BooleanType>    33176910 ns     33163314 ns           84 bytes_per_second=904.614M/s
   BM_ReadIndividualRowGroups         18253632 ns     18243651 ns          160 bytes_per_second=5.35289G/s
   BM_ReadMultipleRowGroups           18032877 ns     18022962 ns          157 bytes_per_second=5.41843G/s
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org