You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sha174n (via GitHub)" <gi...@apache.org> on 2026/05/06 15:58:15 UTC

Re: [PR] fix(reports): enforce server-side recipient on chart/dashboard report subscriptions [superset]

sha174n commented on code in PR #38847:
URL: https://github.com/apache/superset/pull/38847#discussion_r3196475855


##########
superset/commands/report/update.py:
##########
@@ -89,6 +97,26 @@ def validate(self) -> None:  # noqa: C901
         ):
             self._properties["last_state"] = ReportState.NOOP
 
+        # For reports created from charts or dashboards the recipient must always
+        # be the requesting user's own email address.
+        if (

Review Comment:
   The `/api/v1/report/subscribe` endpoint added in this PR is exactly the separate endpoint you're describing. Gamma users get `can_subscribe` permission (not `can_write`), and the endpoint derives `creation_method` server-side from the chart/dashboard object — no client-supplied value. The regular `POST /api/v1/report/` still requires `can_write` (admins). The two flows are separated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org