[GitHub] [incubator-skywalking] ascrutae edited a comment on issue #2292: mysql-8x-plugin and multihost support for mysql5.x

[GitBox <gi...@apache.org>]

ascrutae edited a comment on issue #2292: mysql-8x-plugin and multihost support for mysql5.x
URL: https://github.com/apache/incubator-skywalking/pull/2292#issuecomment-471281129
 
 
   > I prefer to each MySQL plugin has its instrumentation file. Just like this.
   
   Because I saw that every instrumentation file in `mysql-5.x-plugin` have implements `witnessClasses` method, and I smell some bad code smells. So I suggest that each plugin has its instrumentation file, e.g., `Mysql5Instrumentation`. It implements `witnessClasses` method and all instrumentation file extend this class.
   
   >I saw some interceptors classes are duplicate, and I suggest that those the class should move to the project jdbc-common.
   
   My main proposal is that move the duplicate code into one place. I think your suggestion is better than mine, please follow your way. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services