You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2004/03/15 17:41:30 UTC
Re: svn commit: r9034 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_wc
Thanks for doing this, djh. I made two changes to your log message:
- Use forward slashes in paths instead of backslashes.
- Write out function names instead of hiding them in "*". See the
HACKING file for why. Search for the sentence "Don't hide names
in wildcards, because the globbed portion may be what someone
searches for later." :-)
No big deal, just pointing it out for next time. r9034 is already fixed.
-Karl
djh@tigris.org writes:
> Author: djh
> Date: Sat Mar 13 18:08:21 2004
> New Revision: 9034
> Log:
> Rename the new *_depth functions, update call sites (and some
> comments), and mark the old functions as deprecated.
>
> * subversion\include\svn_wc.h
> Rename new svn_wc_adm_*_depth functions to svn_wc_adm_*2 and
> mark the old functions as deprecated.
>
> * subversion\libsvn_wc\wc.h
> * subversion\libsvn_wc\copy.c
> * subversion\libsvn_wc\log.c
> * subversion\libsvn_wc\adm_ops.c
> * subversion\libsvn_wc\status.c
> * subversion\libsvn_wc\adm_files.c
> * subversion\libsvn_wc\lock.c
> * subversion\libsvn_wc\update_editor.c
> * subversion\libsvn_client\relocate.c
> * subversion\libsvn_client\switch.c
> * subversion\libsvn_client\delete.c
> * subversion\libsvn_client\externals.c
> * subversion\libsvn_client\export.c
> * subversion\libsvn_client\revisions.c
> * subversion\libsvn_client\status.c
> * subversion\libsvn_client\prop_commands.c
> * subversion\libsvn_client\url.c
> * subversion\libsvn_client\checkout.c
> * subversion\libsvn_client\revert.c
> * subversion\libsvn_client\diff.c
> * subversion\libsvn_client\copy.c
> * subversion\libsvn_client\log.c
> * subversion\libsvn_client\update.c
> * subversion\libsvn_client\resolved.c
> * subversion\libsvn_client\commit_util.c
> * subversion\libsvn_client\add.c
> * subversion\libsvn_client\commit.c
> * subversion\clients\cmdline\switch-cmd.c
> * subversion\clients\cmdline\main.c
> * subversion\clients\cmdline\propedit-cmd.c
> * subversion\clients\cmdline\info-cmd.c
> Update svn_wc_adm_* calls and comments to the new depth aware
> versions of those functions.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9034 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_wc
Posted by Ben Reser <be...@reser.org>.
On Tue, Mar 16, 2004 at 10:51:14AM -0600, kfogel@collab.net wrote:
> Yeah, those should definitely be forward slashes, yes. Those paths
> are repository fs paths, which always use "/". I've filed issue
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=1790
>
> which includes a guess at the problem spot(s) in the code. I don't
> have a Windows box here to test out a solution; want to have a go?
I don't either. But I'm attaching the patch to the issue momentarily so
maybe someone who isn't as familiar with the code but that does have a
Windows box can test it.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9034 - in trunk/subversion: clients/cmdline include
libsvn_client libsvn_wc
Posted by "D.J. Heap" <dj...@shadyvale.net>.
kfogel@collab.net wrote:
[snip]
>
> Yeah, those should definitely be forward slashes, yes. Those paths
> are repository fs paths, which always use "/". I've filed issue
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=1790
>
> which includes a guess at the problem spot(s) in the code. I don't
> have a Windows box here to test out a solution; want to have a go?
>
> -K
Sure, though it will likely be this weekend before I can do much.
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9034 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_wc
Posted by kf...@collab.net.
"D.J. Heap" <dj...@shadyvale.net> writes:
> Thanks, I'll be more careful in the future. I've noticed that 'svn
> log -v' is returning backslash paths in the 'Changed paths' list on
> Windows...Probably just one too many svn_path_local_style calls in the
> log callback, but I haven't really looked into it yet. Unless they
> are not the relative urls I think they are?
Yeah, those should definitely be forward slashes, yes. Those paths
are repository fs paths, which always use "/". I've filed issue
http://subversion.tigris.org/issues/show_bug.cgi?id=1790
which includes a guess at the problem spot(s) in the code. I don't
have a Windows box here to test out a solution; want to have a go?
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9034 - in trunk/subversion: clients/cmdline include
libsvn_client libsvn_wc
Posted by "D.J. Heap" <dj...@shadyvale.net>.
kfogel@collab.net wrote:
> Thanks for doing this, djh. I made two changes to your log message:
>
> - Use forward slashes in paths instead of backslashes.
> - Write out function names instead of hiding them in "*". See the
> HACKING file for why. Search for the sentence "Don't hide names
> in wildcards, because the globbed portion may be what someone
> searches for later." :-)
>
> No big deal, just pointing it out for next time. r9034 is already fixed.
>
> -Karl
Thanks, I'll be more careful in the future. I've noticed that 'svn log
-v' is returning backslash paths in the 'Changed paths' list on
Windows...Probably just one too many svn_path_local_style calls in the
log callback, but I haven't really looked into it yet. Unless they are
not the relative urls I think they are?
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org