You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com> on 2017/03/14 02:44:50 UTC
Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not
correct
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
Bugs: AMBARI-20437
https://issues.apache.org/jira/browse/AMBARI-20437
Repository: ambari
Description
-------
As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead
and properties's display_unit is MB
So in heatmap's page,values should be $
{dfs.datanode.BytesRead._rate/1024}
MB
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc
Diff: https://reviews.apache.org/r/57583/diff/1/
Testing
-------
done it
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read
maybe not correct
Posted by Nate Cole <nc...@hortonworks.com>.
> On March 15, 2017, 11:24 a.m., Nate Cole wrote:
> > LGTM, make sure a UI person reviews.
>
> zhangxiaolu zhangxiaolu wrote:
> Yes, of course.Could you provide some UI person for me? I'm not sure who are experts.I just know you and yusaku.Thanks a lot.
You have them already on this review.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/#review169016
-----------------------------------------------------------
On March 13, 2017, 10:46 p.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57583/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 10:46 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
>
>
> Bugs: AMBARI-20437
> https://issues.apache.org/jira/browse/AMBARI-20437
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead
> and properties's display_unit is MB
> So in heatmap's page,values should be $
> {dfs.datanode.BytesRead._rate/1024}
> MB
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc
>
>
> Diff: https://reviews.apache.org/r/57583/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20437.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read
maybe not correct
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u4e09\u6708 15, 2017, 3:24 p.m., Nate Cole wrote:
> > LGTM, make sure a UI person reviews.
Yes, of course.Could you provide some UI person for me? I'm not sure who are experts.I just know you and yusaku.Thanks a lot.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/#review169016
-----------------------------------------------------------
On \u4e09\u6708 14, 2017, 2:46 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57583/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 14, 2017, 2:46 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
>
>
> Bugs: AMBARI-20437
> https://issues.apache.org/jira/browse/AMBARI-20437
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead
> and properties's display_unit is MB
> So in heatmap's page,values should be $
> {dfs.datanode.BytesRead._rate/1024}
> MB
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc
>
>
> Diff: https://reviews.apache.org/r/57583/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20437.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read
maybe not correct
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/#review169016
-----------------------------------------------------------
Ship it!
LGTM, make sure a UI person reviews.
- Nate Cole
On March 13, 2017, 10:46 p.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57583/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 10:46 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
>
>
> Bugs: AMBARI-20437
> https://issues.apache.org/jira/browse/AMBARI-20437
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead
> and properties's display_unit is MB
> So in heatmap's page,values should be $
> {dfs.datanode.BytesRead._rate/1024}
> MB
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc
>
>
> Diff: https://reviews.apache.org/r/57583/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20437.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read
maybe not correct
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/
-----------------------------------------------------------
(Updated \u4e09\u6708 14, 2017, 2:46 a.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
Bugs: AMBARI-20437
https://issues.apache.org/jira/browse/AMBARI-20437
Repository: ambari
Description
-------
As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead
and properties's display_unit is MB
So in heatmap's page,values should be $
{dfs.datanode.BytesRead._rate/1024}
MB
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc
Diff: https://reviews.apache.org/r/57583/diff/1/
Testing
-------
done it
File Attachments (updated)
----------------
AMBARI-20437.patch
https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch
Thanks,
zhangxiaolu zhangxiaolu