[GitHub] [iceberg] openinx commented on a change in pull request #1836: Core: Add data and delete writers in FileAppenderFactory.

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #1836:
URL: https://github.com/apache/iceberg/pull/1836#discussion_r533100045



##########
File path: data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java
##########
@@ -42,10 +47,25 @@
 public class GenericAppenderFactory implements FileAppenderFactory<Record> {
 
   private final Schema schema;
+  private final PartitionSpec spec;
+  private final int[] equalityFieldIds;
+  private final Schema eqDeleteRowSchema;
+  private final Schema posDeleteRowSchema;
   private final Map<String, String> config = Maps.newHashMap();
 
-  public GenericAppenderFactory(Schema schema) {
+  public GenericAppenderFactory(Schema schema, PartitionSpec spec) {
+    this(schema, spec, null, schema, null);

Review comment:
       OK, it's more reasonable to set the `eqDeleteRowSchema` to be null when `equalityFieldIds` is null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org