You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/03 22:31:38 UTC
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #36:
Replace more deprecated and unused code
elharo opened a new pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36
@eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull
request #36: Replace more deprecated and unused code
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36#discussion_r389337306
##########
File path: src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java
##########
@@ -124,7 +119,7 @@ public Dependency getDependency() {
ArgumentCaptor<String> captor = ArgumentCaptor.forClass( String.class );
verify( log ).debug( captor.capture() );
- assertThat( captor.getValue(), containsString( "Skipped dependency" ) );
+ assertTrue( captor.getValue().contains( "Skipped dependency" ) );
Review comment:
revert This.
`assertTrue` and the old JUnit assertios are the bad practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #36: Replace more deprecated and unused code
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36#discussion_r389362800
##########
File path: src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java
##########
@@ -163,8 +158,6 @@ public Dependency getDependency() {
}
};
- final boolean result = filter.accept( node , Collections.<Node>emptyList() );
-
- assertThat( result, is( true ));
+ assertTrue( filter.accept( node , Collections.<Node>emptyList() ) );
Review comment:
This is standard JUnit, not Hamcrest. AssertJ would add an extra dependency we don't currently use or need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #36: Replace more deprecated and unused code
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36#discussion_r389362808
##########
File path: src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java
##########
@@ -124,7 +119,7 @@ public Dependency getDependency() {
ArgumentCaptor<String> captor = ArgumentCaptor.forClass( String.class );
verify( log ).debug( captor.capture() );
- assertThat( captor.getValue(), containsString( "Skipped dependency" ) );
+ assertTrue( captor.getValue().contains( "Skipped dependency" ) );
Review comment:
Reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo merged pull request #36: Replace
more deprecated and unused code
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull
request #36: Replace more deprecated and unused code
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #36: Replace more deprecated and unused code
URL: https://github.com/apache/maven-dependency-plugin/pull/36#discussion_r389337332
##########
File path: src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java
##########
@@ -163,8 +158,6 @@ public Dependency getDependency() {
}
};
- final boolean result = filter.accept( node , Collections.<Node>emptyList() );
-
- assertThat( result, is( true ));
+ assertTrue( filter.accept( node , Collections.<Node>emptyList() ) );
Review comment:
Here as well and use AssertJ instead of Java Hamcrest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services