You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/01/24 19:26:35 UTC

[Bug 5304] New: move 'WHITELIST AND BLACKLIST OPTIONS' POD doc back to Conf.pm

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5304

           Summary: move 'WHITELIST AND BLACKLIST OPTIONS' POD doc back to
                    Conf.pm
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: jm@jmason.org


I've just noticed -- as part of the pluginifying of EvalTests.pm, the following
section of POD doc was moved to lib/Mail/SpamAssassin/Plugin/WLBLEval.pm:

=head2 WHITELIST AND BLACKLIST OPTIONS

including the following config settings:

=item whitelist_from add@ress.com
=item unwhitelist_from add@ress.com
=item whitelist_from_rcvd addr@lists.sourceforge.net sourceforge.net
=item def_whitelist_from_rcvd addr@lists.sourceforge.net sourceforge.net
=item whitelist_allows_relays add@ress.com
=item unwhitelist_from_rcvd add@ress.com
=item blacklist_from add@ress.com
=item unblacklist_from add@ress.com
=item whitelist_to add@ress.com
=item more_spam_to add@ress.com
=item all_spam_to add@ress.com
=item blacklist_to add@ress.com


IMO, these are all very important, basic configuration settings, and I don't
think it's good for usability to have them documented in that less-than-obvious
place; plus it leaves dangling references in Conf.pm.

 I'm fine with leaving the implementation of the eval tests in WLBLEval.pm, but
I think we should move the config items, and their doc, back to Conf.pm.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5304] move 'WHITELIST AND BLACKLIST OPTIONS' POD doc back to Conf.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5304


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From jm@jmason.org  2007-01-25 05:03 -------
ok, done:

: jm 378...; svn commit -m "bug 5304: move documentation for whitelist_from,
whitelist_from_rcvd, unwhitelist_from, def_whitelist_from_rcvd,
whitelist_allows_relays, unwhitelist_from_rcvd, blacklist_from,
unblacklist_from, whitelist_to, more_spam_to, all_spam_to, and blacklist_to,
back to Conf.pm from Mail/SpamAssassin/Plugin/WLBLEval.pm -- since they are
basic config settings, frequently used by endusers and documentation needs to be
easily accessible."
Sending        lib/Mail/SpamAssassin/Conf.pm
Sending        lib/Mail/SpamAssassin/Plugin/WLBLEval.pm
Transmitting file data ..
Committed revision 499778.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5304] move 'WHITELIST AND BLACKLIST OPTIONS' POD doc back to Conf.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5304


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.2.0






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5304] move 'WHITELIST AND BLACKLIST OPTIONS' POD doc back to Conf.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5304


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From jm@jmason.org  2007-01-24 10:30 -------
oh yeah -- also, these are the only config items that were moved out of Conf.pm
to Plugins/*Eval.pm (I checked).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.