You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/10/15 18:03:28 UTC
Review Request 39340: RegistryClient: Added streaming response read
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 11:23 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased.
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Nov. 1, 2015, 3:35 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased.
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 5:20 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
removed defers
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 4:55 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fixed offset based write
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review102852
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39013, 38443, 39184, 39155, 39156, 38579, 39014, 39068, 38941, 39015, 39016, 39017, 39053, 39112, 39340]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2015, 12:15 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 12:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient: Added streaming response read
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
>
> Diff: https://reviews.apache.org/r/39340/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Oct. 16, 2015, 12:15 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fixed io::write to use the correct write overload.
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
-----------------------------------------------------------
(Updated Oct. 15, 2015, 9:23 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fixed total read count
Repository: mesos
Description
-------
RegistryClient: Added streaming response read
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39340: RegistryClient: Added streaming response
read
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review102793
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39013, 38443, 39184, 39155, 39156, 38579, 39014, 39068, 38941, 39015, 39016, 39017, 39053, 39112, 39340]
All tests passed.
- Mesos ReviewBot
On Oct. 15, 2015, 4:03 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 4:03 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient: Added streaming response read
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
>
> Diff: https://reviews.apache.org/r/39340/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>