You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/01 16:39:08 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #4678: Fix atscfg ip_allow gen not using v6 number param
rob05c opened a new pull request #4678:
URL: https://github.com/apache/trafficcontrol/pull/4678
## What does this PR (Pull Request) do?
Fixes ORT config generation not using the `coalesce_number_v6` Parameter.
Includes tests.
No docs, no interface change.
Includes changelog.
- [x] This PR is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Ops ORT
## What is the best way to verify this PR?
Run unit tests.
Run ORT against a Traffic Ops with a custom `coalesce_number_v6` parameter, verify the generated ip_allow.config IPv6 addresses are collapsed according to the Parameter and not the default of 5.
## If this is a bug fix, what versions of Traffic Control are affected?
- 4.0.0
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #4678: Fix atscfg ip_allow gen not using v6 number param
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #4678:
URL: https://github.com/apache/trafficcontrol/pull/4678#issuecomment-622469956
Rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #4678: Fix atscfg ip_allow gen not using v6 number param
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #4678:
URL: https://github.com/apache/trafficcontrol/pull/4678#issuecomment-622468901
Oh, there is a merge conflict with CHANGELOG.md -- @rob05c once you rebase I will merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org