You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/13 13:31:44 UTC

[GitHub] [airflow] kaxil opened a new pull request #6813: [AIRFLOW-XXX] Bump Jira version to fix issue with async

kaxil opened a new pull request #6813: [AIRFLOW-XXX] Bump Jira version to fix issue with async
URL: https://github.com/apache/airflow/pull/6813
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
   Internal just for Dev.
   
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Because async is now a reserved keywor we need to bump JIRA version
   ```python
   Traceback (most recent call last):
     File "./dev/airflow-jira", line 25, in <module>
       import jira
     File "/Users/kaxilnaik/opt/anaconda3/lib/python3.7/site-packages/jira/__init__.py", line 10, in <module>
       from jira.client import Comment  # noqa: E402
     File "/Users/kaxilnaik/opt/anaconda3/lib/python3.7/site-packages/jira/client.py", line 337
       validate=False, get_server_info=True, async=False, logging=True, max_retries=3, proxies=None,
                                                 ^
   SyntaxError: invalid syntax
   ```
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   n/a
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services