[GitHub] [superset] jileeon commented on a diff in pull request #21070: feat(embedded): provides filter bar visibility setting on embedded dashboard (#21069)

["jileeon (via GitHub)" <gi...@apache.org>]

jileeon commented on code in PR #21070:
URL: https://github.com/apache/superset/pull/21070#discussion_r1133474068


##########
superset-embedded-sdk/src/index.ts:
##########
@@ -34,6 +37,11 @@ export type UiConfigType = {
   hideTitle?: boolean
   hideTab?: boolean
   hideChartControls?: boolean
+  filters?: {
+    [key: string]: boolean | undefined
+    visible?: boolean
+    expanded?: boolean

Review Comment:
   Hi @jayakrishnankk, Sorry for the late reply. 
   
   these code you wrote are just for complying with Typescript lint.
   I think there are no need to keep them If they should be changed.
   
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org