You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/22 17:39:49 UTC

[GitHub] [spark] squito edited a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

squito edited a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#issuecomment-545073694
 
 
   I'll have to do another thorough review, but one point -- I think that we should have everything which depends on threadlocals (`sc.setJobDescription()` etc. ) throw an error, or at the very least warn loudly, if you use them if you're not in pinned mode.  wdyt?
   
   thanks for taking a deeper look at the failures and addressing them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org