You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Gurkan Erdogdu (JIRA)" <ji...@apache.org> on 2011/01/06 15:46:45 UTC
[jira] Created: (OWB-514) Leak in ELContextStore
Leak in ELContextStore
----------------------
Key: OWB-514
URL: https://issues.apache.org/jira/browse/OWB-514
Project: OpenWebBeans
Issue Type: Bug
Components: Core
Affects Versions: 1.0.0
Reporter: Gurkan Erdogdu
Assignee: Gurkan Erdogdu
Fix For: 1.1.0
In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-514) Leak in ELContextStore
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978700#action_12978700 ]
Gurkan Erdogdu commented on OWB-514:
------------------------------------
Instead of registering EL resolver programmatically (there are some problems on JSF initialization), will check OWB flag in EL resolver. OWB flag is set in WebBeansConfigurationListener # contextInitialized.
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-514) Leak in ELContextStore
Posted by "YING WANG (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978849#action_12978849 ]
YING WANG commented on OWB-514:
-------------------------------
Hi Gurkan, I have some troube to locate AbstractOwbJsfPlugin.java and get some compile errors.
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-514) Leak in ELContextStore
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999306#comment-12999306 ]
Mark Struberg commented on OWB-514:
-----------------------------------
beans.xml location doesn't work in tests and in situations where beans only got added via extensions (e.g. XML config extension only)
But we could of course track the usage by checking if custom beans got added to the BeanManager. 'custom beans' only means that we must not check BeanManagerBean etc...
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Mark Struberg
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (OWB-514) Leak in ELContextStore
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved OWB-514.
-------------------------------
Resolution: Fixed
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Mark Struberg
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-514) Leak in ELContextStore
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999334#comment-12999334 ]
Mark Struberg commented on OWB-514:
-----------------------------------
fixed by utilizing BeanManagerImpl#isInUse() (see OWB-532)
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Mark Struberg
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OWB-514) Leak in ELContextStore
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gurkan Erdogdu closed OWB-514.
------------------------------
Resolution: Fixed
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OWB-514) Leak in ELContextStore
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reopened OWB-514:
-------------------------------
Assignee: Mark Struberg (was: Gurkan Erdogdu)
This currently breaks the WebBeansELResolver for all non-JSF apps (always returns null).
What about simply checking if the scanner service at least found 1 beansXmlLocation? If non found, then we can disable the OWB EL resolval. In all other cases it should be enabled.
> Leak in ELContextStore
> ----------------------
>
> Key: OWB-514
> URL: https://issues.apache.org/jira/browse/OWB-514
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Gurkan Erdogdu
> Assignee: Mark Struberg
> Fix For: 1.1.0
>
>
> In current code, ELContextStore is leaked. When you put openwebbeans-jsf.jar into server global classpath, even non OWB applications uses WebBeansELResolver because it is registered in faces-config.xml.
> I will create a new JSF plugin to register WebBeansELResolver programatically if application is OWB. And removing el-resolver from faces-config.xml
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira