You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/10 18:56:12 UTC

[GitHub] ZiyueHuang commented on issue #10882: move exec.reshape to backend

ZiyueHuang commented on issue #10882: move exec.reshape to backend
URL: https://github.com/apache/incubator-mxnet/pull/10882#issuecomment-388150995
 
 
   Thanks for your comments.
   For the unit tests part, I found the existing tests cover both up sizing and down sizing, https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_module.py#L703, https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_module.py#L205, https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_executor.py#L144.
   Will address other parts tomorrow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services