You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/01/05 05:52:07 UTC
[GitHub] zeppelin pull request #1844: [ZEPPELIN-1825] Use versioned notebook storage ...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1844
[ZEPPELIN-1825] Use versioned notebook storage by default
### What is this PR for?
Due to recent work on versioned notes under ZEPPELIN-1044, we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it.
### What type of PR is it?
Improvement | Refactoring
### Todos
* [x] - change VFS to Git
### What is the Jira issue?
[ZEPPELIN-1825](https://issues.apache.org/jira/browse/ZEPPELIN-1825)
### How should this be tested?
start zeppelin and by default be able to use version control (if git client installed)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1844.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1844
----
commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-05T05:24:50Z
modify default storage to git repo
commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-05T05:32:01Z
fix in zeppelin-site.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1844: [ZEPPELIN-1825] Use versioned notebook storage ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1844: [ZEPPELIN-1825] Use versioned notebook storage ...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1844
thanks @AhyoungRyu, updated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1844
`VFSNotebookRepo` can be configured to use [other filesystems](https://commons.apache.org/proper/commons-vfs/filesystems.html) instead of local filesystem.
Those user might be confused when (default) notebook repo is changed to `GitNotebookRepo`.
How about add an item in [upgrade.md](https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07) for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1844
@khalidhuseynov Seems a default value of `ZEPPELIN_NOTEBOOK_STORAGE ` under [Apache Zeppelin configuration](https://github.com/apache/zeppelin/blob/master/docs/install/install.md#apache-zeppelin-configuration) table also needs to be updated :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1844
@Leemoonsoo makes sense, added in 7cb133c8dc59357b0572c4f462ae04d5bbb55cce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1844
@felixcheung i didn't see much places to update docs, but maybe @AhyoungRyu knows if there's something to be updated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1844: [ZEPPELIN-1825] Use versioned notebook storage ...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1844
[ZEPPELIN-1825] Use versioned notebook storage by default
### What is this PR for?
Due to recent work on versioned notes under ZEPPELIN-1044, we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it.
### What type of PR is it?
Improvement | Refactoring
### Todos
* [x] - change VFS to Git
### What is the Jira issue?
[ZEPPELIN-1825](https://issues.apache.org/jira/browse/ZEPPELIN-1825)
### How should this be tested?
start zeppelin and by default be able to use version control (if git client installed)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1844.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1844
----
commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-05T05:24:50Z
modify default storage to git repo
commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-05T05:32:01Z
fix in zeppelin-site.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1844
LGTM
any documentation to update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1844
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1844
Thanks @khalidhuseynov for the improvement.
LGTM and merge if no more comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---