[jira] [Commented] (MGPG-135) Support Overriding / Enhance the signer in AbstractGpgMojo

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MGPG-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872703#comment-17872703 ] 

ASF GitHub Bot commented on MGPG-135:
-------------------------------------

laeubi opened a new pull request, #112:
URL: https://github.com/apache/maven-gpg-plugin/pull/112

   Currently AbstractGpgMojo has a fixed set of supported signers (and how they are constructed), it would be good to allow extensions (e.g. Tycho is also using AbstractGpgMojo) to possibly override that aspect.
   
   This extracts the creation of the signer into a (protected) method so different types or alternative implementations can be used.
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MGPG-135) filed for the change (usually
     before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should
     address just this issue, without pulling in other changes.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] Format the pull request title like `[MGPG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MGPG-XXX`
     with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the
     first line of the commit message.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull
     request automatically.
   - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the
   developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licenced under
     the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file
     an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).




> Support Overriding / Enhance the signer in AbstractGpgMojo
> ----------------------------------------------------------
>
>                 Key: MGPG-135
>                 URL: https://issues.apache.org/jira/browse/MGPG-135
>             Project: Maven GPG Plugin
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently AbstractGpgMojo has a fixed set of supported signers (and how they are constructed), it would be good to allow extensions (e.g. Tycho is also using AbstractGpgMojo) to possibly override that aspect.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)