You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/12/21 23:18:30 UTC
[incubator-superset] 02/02: update messaging
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/change-ds-bugfixes
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit c5c95dc4378affcad7cd3a7c94a1afde02ab3571
Author: hughhhh <hu...@gmail.com>
AuthorDate: Mon Dec 21 18:17:50 2020 -0500
update messaging
---
superset-frontend/src/datasource/ChangeDatasourceModal.tsx | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
index e6de5ed..0b99cd8 100644
--- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
+++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
@@ -36,7 +36,12 @@ import Loading from '../components/Loading';
import withToasts from '../messageToasts/enhancers/withToasts';
const CONFIRM_WARNING_MESSAGE = t(
- 'Warning! Changing the dataset may break the chart if the metadata (columns/metrics) does not exist in the target dataset',
+ 'Warning! Changing the dataset may break the chart if the metadata does not exist.',
+);
+
+const CHANGE_WARNING_MSG = t(
+ 'Changing the dataset may break the chart if the chart relies ' +
+ 'on columns or metadata that does not exist in the target dataset',
);
interface Datasource {
@@ -75,10 +80,6 @@ const TABLE_COLUMNS = [
'creator',
].map(col => ({ accessor: col, Header: col }));
-const CHANGE_WARNING_MSG = t(
- 'Warning changing the dataset may break the chart if the metadata does not exist.'
-);
-
const emptyRequest = {
pageIndex: 0,
pageSize: 20,