You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/06 02:14:28 UTC
[GitHub] [flink] becketqin opened a new pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
becketqin opened a new pull request #12507:
URL: https://github.com/apache/flink/pull/12507
## What is the purpose of the change
The `AddSplitsEvent` contains a list of `SourceSplit` to be sent from the source coordinator to the source reader. Currently the `AddSplitsEvent` is a serializable but the `SourceSplit` is not serializable as we expect the users to provide a split serializer. In order to make sure the `AddSplitsEvent` is serializable, we need to use the user provided split serializer to save the serialized splits in the `AddSplitsEvent` instead of having the split objects.
## Brief change log
90d421fc94e29c0af0fa563661b9dd8f2a388b1b changes the `AddSplitsEvent` to save the serialized splits instead of the original instance.
## Verifying this change
Existing unit tests covers the change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on a change in pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #12507:
URL: https://github.com/apache/flink/pull/12507#discussion_r438741095
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/event/AddSplitEvent.java
##########
@@ -30,15 +33,23 @@ Licensed to the Apache Software Foundation (ASF) under one
public class AddSplitEvent<SplitT> implements OperatorEvent {
private static final long serialVersionUID = 1L;
-
- private final List<SplitT> splits;
-
- public AddSplitEvent(List<SplitT> splits) {
- this.splits = splits;
+ private final int serializerVersion;
+ private final List<byte[]> splits;
Review comment:
Nit: For serializable classes it is nice to put the concrete type of the list there, because not all list implementations are serializable. And because this is a purely internal field, typing this to `ArrayList` wouldn't change any abstractions.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContextTest.java
##########
@@ -71,16 +72,16 @@ public void testUnregisterReader() {
}
@Test
- public void testAssignSplitsFromCoordinatorExecutor() throws ExecutionException, InterruptedException {
+ public void testAssignSplitsFromCoordinatorExecutor() throws ExecutionException, InterruptedException, IOException {
Review comment:
Nit: For tests it is often easier to just declare `throws Exception`, rather than have a long list of individual exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-644555205
Merged to master:
f883f1190132f9dd6b37f1e5c8ae0e0d25f78333
Cherry-picked to release-1.11:
6cf60fda000d25baddfd7a2c3725eeecba77f886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90d421fc94e29c0af0fa563661b9dd8f2a388b1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855)
* 0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90d421fc94e29c0af0fa563661b9dd8f2a388b1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
}, {
"hash" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3521",
"triggerID" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488)
* 0a30a84afa84685bb5587a962fd27f2207a0c6f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90d421fc94e29c0af0fa563661b9dd8f2a388b1b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484)
* 4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90d421fc94e29c0af0fa563661b9dd8f2a388b1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639957918
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 90d421fc94e29c0af0fa563661b9dd8f2a388b1b (Sat Jun 06 02:16:13 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
}, {
"hash" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3521",
"triggerID" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a30a84afa84685bb5587a962fd27f2207a0c6f4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
}, {
"hash" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a30a84afa84685bb5587a962fd27f2207a0c6f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488)
* 0a30a84afa84685bb5587a962fd27f2207a0c6f4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2855",
"triggerID" : "90d421fc94e29c0af0fa563661b9dd8f2a388b1b",
"triggerType" : "PUSH"
}, {
"hash" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484",
"triggerID" : "0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4",
"triggerType" : "PUSH"
}, {
"hash" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488",
"triggerID" : "4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0670d44c13aa29f678e7aeb9e2e8ca7f4c67b4d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3484)
* 4979d62b3d3d5c80e8c04d93f82ca0946eafdc4b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin closed pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
becketqin closed pull request #12507:
URL: https://github.com/apache/flink/pull/12507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12507:
URL: https://github.com/apache/flink/pull/12507#issuecomment-639958697
@StephanEwen Could you help take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org