Re: apr_queue_t enhancement - please review for inclusion

[Ryan Phillips <ry...@trolocsis.com>]

Yossi Neiman <fr...@cartissolutions.com> said:
> Hi everybody,
> 
> I worked up some enhancements to the apr_queue.c/h files, basically 
> allowing manually blocking of push and/or pop, and also providing a 
> function that will block until the queue is empty.  I've already used 
> this in some code that I have written for FreeSWITCH to allow for a safe 
> reload of the configuration file for my module.  Hopefully you will 
> think that this is useful for the rest of the world to be able to use.  
> Patches included in the bug.
> 
> http://issues.apache.org/bugzilla/show_bug.cgi?id=41254
> 

I would find this patch useful.  One problem I see with the patch is
that 'rv' is used uninitialized a few times:

{
    apr_status_t rv;

    if (!queue->terminated) {
        ...
    }

    return rv;
}

-ryan

Re: apr_queue_t enhancement - please review for inclusion

[Yossi Neiman <fr...@cartissolutions.com>]

See below.

Ryan Phillips wrote:
> Yossi Neiman <fr...@cartissolutions.com> said:
<snip snip>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=41254
>>
> 
> I would find this patch useful.  One problem I see with the patch is
> that 'rv' is used uninitialized a few times:
> 
> {
>     apr_status_t rv;
> 
>     if (!queue->terminated) {
>         ...
>     }
> 
>     return rv;
> }
> 
> -ryan

How right you are.  I have fixed this error and have posted updated 
patches to the bugtracker (under the same issue of course).  I'm glad 
that this is of interest to you.

-Yossi