You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zach Amsden (Code Review)" <ge...@cloudera.org> on 2017/09/23 01:51:19 UTC
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8132
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
IMPALA-5975: Work around broken beeline clients
To make statements execute, some clients require always appending
a semi-colon to the end. The workaround is quite simple.
Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
---
M testdata/bin/create-load-data.sh
M testdata/bin/create-table-many-blocks.sh
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/8132/1
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1:
I tested this with a local data load, but we need to kick off a GVO run as well.
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Sep 2017 19:56:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1:
I will do that now.
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Sep 2017 02:10:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 2: Code-Review+2
Carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Sep 2017 23:25:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1: Code-Review+2
Omg, sorry you had to dig into this
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Sep 2017 03:19:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1: Code-Review+1
This seems fine to me. Have we filed a bug for the relevant beeline client for the misbehavior?
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Sep 2017 02:09:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1268/
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Sep 2017 23:26:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
IMPALA-5975: Work around broken beeline clients
To make statements execute, some clients require always appending
a semi-colon to the end. The workaround is quite simple.
Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Reviewed-on: http://gerrit.cloudera.org:8080/8132
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/bin/create-load-data.sh
M testdata/bin/create-table-many-blocks.sh
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Sep 2017 03:27:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1:
Thanks for testing! Still lgtm.
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Sep 2017 22:39:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
......................................................................
Patch Set 1:
From private build and test 6418,
14:21:05 Executing: create-load-data.sh
14:21:05 Loading Hive Builtins (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-hive-builtins.log)...
14:23:20 OK (Took: 2 min 15 sec)
14:23:20 Generating HBase data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/create-hbase.log)...
14:23:49 OK (Took: 0 min 29 sec)
14:23:49 Creating /test-warehouse HDFS directory (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/create-test-warehouse-dir.log)...
14:23:53 OK (Took: 0 min 4 sec)
14:23:53 Derived params for create-load-data.sh:
14:23:53 EXPLORATION_STRATEGY=exhaustive
14:23:53 SKIP_METADATA_LOAD=0
14:23:53 SKIP_SNAPSHOT_LOAD=0
14:23:53 SNAPSHOT_FILE=
14:23:53 CM_HOST=
14:23:53 REMOTE_LOAD=
14:23:53 Starting Impala cluster (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/start-impala-cluster.log)...
14:24:06 OK (Took: 0 min 13 sec)
14:24:06 Setting up HDFS environment (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/setup-hdfs-env.log)...
14:24:21 OK (Took: 0 min 15 sec)
14:24:21 Loading custom schemas (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-custom-schemas.log)...
14:25:24 OK (Took: 1 min 3 sec)
14:25:24 Loading functional-query data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-functional-query.log)...
15:17:32 OK (Took: 52 min 8 sec)
15:17:32 Loading TPC-H data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-tpch.log)...
15:42:56 OK (Took: 25 min 24 sec)
15:42:56 Loading nested data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-nested.log)...
15:48:33 OK (Took: 5 min 37 sec)
15:48:33 Loading TPC-DS data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-tpcds.log)...
16:16:20 OK (Took: 27 min 46 sec)
16:16:20 Loading auxiliary workloads (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-aux-workloads.log)...
16:27:10 OK (Took: 10 min 51 sec)
16:27:10 Loading dependent tables (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/copy-and-load-dependent-tables.log)...
16:28:18 OK (Took: 1 min 7 sec)
16:28:18 Loading custom data (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-custom-data.log)...
16:30:16 OK (Took: 1 min 58 sec)
16:30:16 Creating many block table (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/create-table-many-blocks.log)...
16:31:18 OK (Took: 1 min 2 sec)
16:31:18 Loading Kudu functional (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-kudu.log)...
16:35:57 OK (Took: 4 min 39 sec)
16:35:57 Loading Kudu TPCH (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-kudu-tpch.log)...
16:42:17 OK (Took: 6 min 20 sec)
16:42:17 Loading Hive UDFs (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/build-and-copy-hive-udfs.log)...
16:43:46 OK (Took: 1 min 29 sec)
16:43:46 Running custom post-load steps (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/custom-post-load-steps.log)...
16:44:20 OK (Took: 0 min 34 sec)
16:44:20 Caching test tables (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/cache-test-tables.log)...
16:44:28 OK (Took: 0 min 8 sec)
16:44:28 Loading external data sources (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/load-ext-data-source.log)...
16:44:39 OK (Took: 0 min 11 sec)
16:44:39 Splitting HBase (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/create-hbase.log)...
16:45:15 OK (Took: 0 min 36 sec)
16:45:15 Creating internal HBase table (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/create-internal-hbase-table.log)...
16:46:01 OK (Took: 0 min 46 sec)
16:46:01 Computing table stats (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/compute-table-stats.log)...
16:58:20 OK (Took: 12 min 20 sec)
16:58:20 Copying auth policy file (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/data_loading/copy-auth-policy.log)...
16:58:29 OK (Took: 0 min 8 sec)
16:58:31 Split and assign HBase regions (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/ee_tests/split-hbase.log)...
16:58:52 OK (Took: 0 min 23 sec)
16:58:52 Starting Impala cluster (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/ee_tests/start-impala-cluster.log)...
16:59:09 OK (Took: 0 min 17 sec)
16:59:09 Run test run-workload (logging to /data/jenkins/workspace/impala-private-build-and-test/repos/Impala/logs/ee_tests/test-run-workload.log)...
16:59:20 OK (Took: 0 min 11 sec)
--
To view, visit http://gerrit.cloudera.org:8080/8132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b9f3dde4445513f1f389785a002c6cc6b3dada
Gerrit-Change-Number: 8132
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Sep 2017 21:45:27 +0000
Gerrit-HasComments: No