You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2026/01/23 01:50:07 UTC
[PR] refactor(CordovaError): drop netflix/nerror dependency [cordova-common]
dpogue opened a new pull request, #247:
URL: https://github.com/apache/cordova-common/pull/247
### Platforms affected
All
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
The `@netflix/nerror` package doesn't seem to be actively maintained, and it has `lodash` as a dependency which is a big source of dependabot security warnings.
### Description
<!-- Describe your changes in detail -->
Implement our own CordovaError mimicking the (few) relevant parts of VError.
There are technically a few breaking changes here, to be discussed:
* I changed the `err.cause()` method to an `err.cause` getter
* This was used in 1 spot in the tests
* I changed the `err.info()` method to an `err.info` getter (unused)
* I did not implement the `err.assignInfo(...)` method (unused)
* Several class-level methods are not implemented because they were not used:
* `assignInfo`
* `findCauseByName`
* `hasCauseWithName`
* `errorFromList`
* `errorForEach`
* `isVError`
### Testing
<!-- Please describe in detail how you tested your changes. -->
Existing tests pass and added test cases to ensure proper code coverage.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor(CordovaError): drop netflix/nerror dependency [cordova-common]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #247:
URL: https://github.com/apache/cordova-common/pull/247#issuecomment-3787749178
## [Codecov](https://app.codecov.io/gh/apache/cordova-common/pull/247?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 95.21%. Comparing base ([`86a9779`](https://app.codecov.io/gh/apache/cordova-common/commit/86a977998c358b3ba33034f76a66bef477330404?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0314e5b`](https://app.codecov.io/gh/apache/cordova-common/commit/0314e5bcd07fddbdd9cf33712ea12eb59fb8a426?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 95.40% 95.21% -0.19%
==========================================
Files 20 20
Lines 3917 3953 +36
==========================================
+ Hits 3737 3764 +27
- Misses 180 189 +9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-common/pull/247?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org