You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/30 22:30:19 UTC
[GitHub] [kafka] vvcephei opened a new pull request #8961: MINOR: add a retry system test curl commands
vvcephei opened a new pull request #8961:
URL: https://github.com/apache/kafka/pull/8961
Adds a retry to curl, using the built-in exponential backoff mechanism.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652085184
@vvcephei `--retry-all-error` is not an option that the current curl version recognizes. The system tests fail early on that error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652081453
Recently, I have seen a few remote (aws-over-vagrant) system tests fail during setup due to this error:
```
worker15: + curl -O https://s3-us-west-2.amazonaws.com/kafka-packages/kafka_2.11-1.1.1.tgz
worker15: % Total % Received % Xferd Average
worker15: Speed Time Time Time
worker15: Current
worker15: Dload Upload Total Spent Left
worker15: Speed
0 0 0 0 0 0 0 0 --:--:--
worker15: --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--
worker15: :-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:03 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:04 --:--:-
worker15: - 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:05 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:06 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:07 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:08 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:09 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:10 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:11 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:12 --:--:--
worker15: 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:13 --:--:-- 0
worker15: curl: (35) Unknown SSL protocol error
worker15: in connection to s3-us
worker15: -west-2.amazonaws.com:443
```
The problem is transient, so it seems to be an issue with the SSL negotiation on the server side. Some reading has suggested it could also be due to networking issues when running inside of containers, or over VPNs, etc., etc.
I didn't find anything obvious we could do about it, so it seems worthwhile to at least attempt to avoid failing the whole run over a transient non-problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add retry to system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652566225
Thanks @kkonstantine and @abbccdda !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652423581
Looks like that one worked: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.1593607328--vvcephei--minor-vagrant-curl-retry--8532458b7/report.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652168931
Ah, Thanks @kkonstantine ,
I see that now:
```
17:42:20 worker5: + curl --retry-all-errors --retry 5 -s -L https://s3-us-west-2.amazonaws.com/kafka-packages/jdk-8u202-linux-x64.tar.gz -o /tmp/jdk-8u202-linux-x64.tar.gz
17:42:20 worker5: curl: option --retry-all-error
17:42:20 worker5: s: is unknown
17:42:20 worker5: curl: try 'curl --help' or 'c
17:42:20 worker5: url --manual' for more information
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8961: MINOR: add retry to system test curl commands
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652554760
Failed tests should be non-related as we only change on system test run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652082007
System test meta run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4001/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #8961: MINOR: add retry to system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #8961:
URL: https://github.com/apache/kafka/pull/8961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652171595
new run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine removed a comment on pull request #8961: MINOR: add a retry system test curl commands
Posted by GitBox <gi...@apache.org>.
kkonstantine removed a comment on pull request #8961:
URL: https://github.com/apache/kafka/pull/8961#issuecomment-652085184
@vvcephei `--retry-all-error` is not an option that the current curl version recognizes. The system tests fail early on that error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org