You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/13 15:27:02 UTC
[GitHub] [airflow] kaxil commented on a change in pull request #13654: Switches to latest version of snowflake connector
kaxil commented on a change in pull request #13654:
URL: https://github.com/apache/airflow/pull/13654#discussion_r556604413
##########
File path: setup.py
##########
@@ -428,14 +428,10 @@ def get_sphinx_theme_version() -> str:
# once it is merged, we can move those two back to `azure` extra.
'azure-storage-blob',
'azure-storage-common',
- # snowflake is not compatible with latest version.
- # This library monkey patches the requests library, so SSL is broken globally.
- # See: https://github.com/snowflakedb/snowflake-connector-python/issues/324
- 'requests<2.24.0',
- # Newest version drop support for old version of azure-storage-blob
- # Until #12188 is solved at least we need to limit maximum version.
- # https://github.com/apache/airflow/pull/12188
- 'snowflake-connector-python>=1.5.2,<=2.3.6',
+ # Snowflake conector > 2.3.8 is needed because it has vendored urrllib3 and requests libraries which
Review comment:
```suggestion
# Snowflake conector > 2.3.8 is needed because it has vendored urllib3 and requests libraries which
```
##########
File path: setup.py
##########
@@ -428,14 +428,10 @@ def get_sphinx_theme_version() -> str:
# once it is merged, we can move those two back to `azure` extra.
'azure-storage-blob',
'azure-storage-common',
- # snowflake is not compatible with latest version.
- # This library monkey patches the requests library, so SSL is broken globally.
- # See: https://github.com/snowflakedb/snowflake-connector-python/issues/324
- 'requests<2.24.0',
- # Newest version drop support for old version of azure-storage-blob
- # Until #12188 is solved at least we need to limit maximum version.
- # https://github.com/apache/airflow/pull/12188
- 'snowflake-connector-python>=1.5.2,<=2.3.6',
+ # Snowflake conector > 2.3.8 is needed because it has vendored urrllib3 and requests libraries which
Review comment:
```suggestion
# Snowflake connector > 2.3.8 is needed because it has vendored urllib3 and requests libraries which
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org