You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/05/04 14:12:06 UTC

[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spa...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2270#discussion_r186094736
  
    --- Diff: assembly/pom.xml ---
    @@ -89,7 +89,18 @@
               <artifactSet>
                 <includes>
                   <include>*:*</include>
    +              <!--use the following line if we only want carbondata related classes-->
    +              <!--<include>org.apache.carbondata:*</include>-->
    --- End diff --
    
    FYI: If we use this line of code, the assembly jar will only contain carbondata related classes and the final size of assembly-jar will be about 7MB.
    
    But there will be some problems: If carbon use an artifact that is not provided by spark, it will cause runtime error. So we'd better to keep the classes and only remove those are known to be provided by spark.


---