You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/04 16:35:30 UTC

[GitHub] merlimat commented on a change in pull request #1729: Include Jackson modules in shaded jar as well

merlimat commented on a change in pull request #1729: Include Jackson modules in shaded jar as well
URL: https://github.com/apache/incubator-pulsar/pull/1729#discussion_r186139625
 
 

 ##########
 File path: pulsar-client-shaded/pom.xml
 ##########
 @@ -74,6 +74,7 @@
                   <include>com.google.guava:guava</include>
                   <include>com.google.code.gson:gson</include>
                   <include>com.fasterxml.jackson.core</include>
+                  <include>com.fasterxml.jackson.module</include>
 
 Review comment:
   The same should also be done for `pulsar-client-admin-shaded` and for kafka wrapper too. Unfortunately we haven't yet found a way to have the shading conf in a single place

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services