You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/22 08:03:14 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #14725: [fix][deploy]: Fix setting BOOKIE_LOG_DIR variable in bkenv.sh takes no effects

eolivelli commented on a change in pull request #14725:
URL: https://github.com/apache/pulsar/pull/14725#discussion_r831868731



##########
File path: bin/pulsar-daemon
##########
@@ -75,6 +70,16 @@ shift
 command=$1
 shift
 
+if [[ "$command" = "bookie" ]]
+then
+  PULSAR_LOG_DIR=${BOOKIE_LOG_DIR:-"$PULSAR_HOME/logs"}

Review comment:
       what happens if a user configured PULSAR_LOG_DIR ?
   we are changing the behaviour and people who upgrade may have bad surprises
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org