You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/12/28 03:25:19 UTC
[PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Xuanwo opened a new pull request, #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836
close https://github.com/apache/incubator-opendal/issues/3736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870838471
Seems like the `--features` override misses `pyo3/extension-module` feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870792282
> I'm not very confident that this will build fine on release, we should verify it on CI before merging.
We have `rcX` for every release, this could be fine.
> Perhaps this should be changed to also allow triggering from workflow_dispatch so we can test it without tagging a release.
Writing the `if` statement seems a bit complex; any suggestions for simplifying it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870819152
Build fails: https://github.com/apache/incubator-opendal/actions/runs/7344504243/job/19996430985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870832923
CI failed for:
```shell
error: could not find native static library `python3.7m`, perhaps an -L flag is missing?
error: could not compile `pyo3-ffi` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
💥 maturin failed
Caused by: Failed to build a native library through cargo
Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_ENVIRONMENT_SIGNATURE="cpython-3.7-64bit" PYO3_PYTHON="/usr/local/bin/python3.7" PYTHON_SYS_EXECUTABLE="/usr/local/bin/python3.7" "cargo" "rustc" "--features" "services-all" "--target" "x86_64-unknown-linux-gnu" "--message-format" "json-render-diagnostics" "--manifest-path" "/home/runner/work/incubator-opendal/incubator-opendal/bindings/python/Cargo.toml" "--release" "--lib"`
Error: The process '/usr/bin/docker' failed with exit code 1
at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870854295
Cool! Thanks @messense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870791089
I'm not very confident that this will build fine on release, we should verify it on CI before merging.
https://github.com/apache/incubator-opendal/blob/6ca583d27af0c3c7e3657a9116a28fdd5c9709f8/.github/workflows/bindings_python.yml#L61
Perhaps this should be changed to also allow triggering from `workflow_dispatch` so we can test it without tagging a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870799184
> Writing the `if` statement seems a bit complex; any suggestions for simplifying it?
https://github.com/apache/incubator-opendal/pull/3837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): Build all available services for python [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3836:
URL: https://github.com/apache/incubator-opendal/pull/3836#issuecomment-1870800295
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org