You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/06/20 20:28:03 UTC
Review Request 48965: add a test case to run query on client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48965/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-1572
https://issues.apache.org/jira/browse/GEODE-1572
Repository: geode
Description
-------
Query from client should have beeen supported, but we need a test case for it.
Diffs
-----
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneDUnitTest.java 565ec4f
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java 26cd4aa
Diff: https://reviews.apache.org/r/48965/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 48965: add a test case to run query on client
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48965/#review138669
-----------------------------------------------------------
Hi Gester,
Nice, thanks for adding a test! But I think it would be better to just extend LuceneQueriesBase with a LuceneQueriesClient test or something. The base class was written such that data stores and accessors were abstract concepts, and the child classes could configure a specific topology. So in LuceneQueriesClientDUnitTest, you could just provide initAccessor and initDataStore methods that make the accessor a client and the data store a server.
- Dan Smith
On June 20, 2016, 8:31 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48965/
> -----------------------------------------------------------
>
> (Updated June 20, 2016, 8:31 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1572
> https://issues.apache.org/jira/browse/GEODE-1572
>
>
> Repository: geode
>
>
> Description
> -------
>
> Query from client should have beeen supported, but we need a test case for it.
>
>
> Diffs
> -----
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java 26cd4aa
>
> Diff: https://reviews.apache.org/r/48965/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 48965: add a test case to run query on client
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48965/
-----------------------------------------------------------
(Updated June 20, 2016, 8:31 p.m.)
Review request for geode and Dan Smith.
Changes
-------
clean up the diff
Bugs: GEODE-1572
https://issues.apache.org/jira/browse/GEODE-1572
Repository: geode
Description
-------
Query from client should have beeen supported, but we need a test case for it.
Diffs (updated)
-----
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java 26cd4aa
Diff: https://reviews.apache.org/r/48965/diff/
Testing
-------
Thanks,
xiaojian zhou