[GitHub] [incubator-dubbo] kexianjun commented on issue #3213: [Dubbo 3151] Optimize heartbeat mechanism

["kexianjun (GitHub)" <gi...@apache.org>]

> Seems like just put the heartbeat into pipeline.
> Personally think that Header's abstraction is better, and about the heartbeat operation (on, off) I think it should still be done in the Header layer. Regarding the details of the heartbeat (check, reconnect), we can implement it in other ways.

I think it's more appropriate to put and start heartbeat in HeartbeatHandler,since its responsibility is as its name described, do something about heartbeat,such as record the last read and write time for recalculating the next heartbeat(or reconnect) task's trigger time, when a channel is connected, start heartbeat tasks for it, and handler heartbeat packets.And as I've suggested in #3151 , each channel has its own heartbeat tasks, we should put heartbeat into handler chain.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3213 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org