You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/22 23:25:34 UTC

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 2:25 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Summary (updated)
-----------------

Add std::unique_ptr and std::move checks to configure script.


Bugs: MESOS-1771
    https://issues.apache.org/jira/browse/MESOS-1771


Repository: mesos-git


Description
-------

Add check to configure script for std::unique_ptr and std::move


Diffs (updated)
-----

  m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 

Diff: https://reviews.apache.org/r/25448/diff/


Testing
-------

make check with g++-4.4 and clang++ (3.5)


Thanks,

Dominic Hamon


Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/#review57931
-----------------------------------------------------------


Patch looks great!

Reviews applied: [25448]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2014, 9:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25448/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 9:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1771
>     https://issues.apache.org/jira/browse/MESOS-1771
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add check to configure script for std::unique_ptr and std::move
> 
> 
> Diffs
> -----
> 
>   m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 
> 
> Diff: https://reviews.apache.org/r/25448/diff/
> 
> 
> Testing
> -------
> 
> make check with g++-4.4 and clang++ (3.5)
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/#review58173
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Oct. 22, 2014, 9:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25448/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 9:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1771
>     https://issues.apache.org/jira/browse/MESOS-1771
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add check to configure script for std::unique_ptr and std::move
> 
> 
> Diffs
> -----
> 
>   m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 
> 
> Diff: https://reviews.apache.org/r/25448/diff/
> 
> 
> Testing
> -------
> 
> make check with g++-4.4 and clang++ (3.5)
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>