You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/07/10 21:02:22 UTC
Re: [PR] feat: Move `IfExpr` to `spark-expr` crate [datafusion-comet]
andygrove commented on code in PR #653:
URL: https://github.com/apache/datafusion-comet/pull/653#discussion_r1673003630
##########
native/spark-expr/src/if_expr.rs:
##########
@@ -165,6 +156,15 @@ mod tests {
use super::*;
+ /// Create an If expression
+ fn if_fn(
+ if_expr: Arc<dyn PhysicalExpr>,
+ true_expr: Arc<dyn PhysicalExpr>,
+ false_expr: Arc<dyn PhysicalExpr>,
+ ) -> Result<Arc<dyn PhysicalExpr>> {
+ Ok(Arc::new(IfExpr::new(if_expr, true_expr, false_expr)))
+ }
Review Comment:
This function is only used in tests, so I moved it into the test module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org