You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/17 10:27:15 UTC
[GitHub] [ozone-docker-runner] smengcl opened a new pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
smengcl opened a new pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11
## What changes were proposed in this pull request?
- Improve Dockerfile to select the right dependencies based on build architecture.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6265
## How was this patch tested?
- [x] Test on x86_64
- [ ] Test on arm64 (M1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] smengcl merged pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
smengcl merged pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] sodonnel commented on pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#issuecomment-1050106346
Thanks for working on this @smengcl. I have checked out this branch locally, built the image and ran a simple 5 DN cluster. So far it seems to be working well, and much faster on the M1 Mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] smengcl commented on a change in pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#discussion_r814111631
##########
File path: Dockerfile
##########
@@ -14,10 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.17.6-buster
-RUN GO111MODULE=off go get -u github.com/rexray/gocsi/csc
-
-FROM centos:7.9.2009
+FROM golang:1.17.7-buster AS go1
+RUN go install github.com/rexray/gocsi/csc@latest
+
+FROM golang:1.17.7-buster AS go2
+# Compile latest goofys for arm64 if necessary, which doesn't have a released binary
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ if [ ${ARCH} = "aarch64" ]; then \
+ git clone https://github.com/kahing/goofys.git ; \
+ cd goofys ; \
Review comment:
Hey @sodonnel , thanks for the comment.
Actually I tried earlier, `v0.24.0` tag wouldn't build on arm64 (in Docker on my M1 Mac). So [some master branch commits](https://github.com/kahing/goofys/compare/v0.24.0...master) probably fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] sodonnel commented on a change in pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#discussion_r814083542
##########
File path: Dockerfile
##########
@@ -14,10 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.17.6-buster
-RUN GO111MODULE=off go get -u github.com/rexray/gocsi/csc
-
-FROM centos:7.9.2009
+FROM golang:1.17.7-buster AS go1
+RUN go install github.com/rexray/gocsi/csc@latest
+
+FROM golang:1.17.7-buster AS go2
+# Compile latest goofys for arm64 if necessary, which doesn't have a released binary
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ if [ ${ARCH} = "aarch64" ]; then \
+ git clone https://github.com/kahing/goofys.git ; \
+ cd goofys ; \
Review comment:
Should we checkout the "v0.24.0" tag before building? Otherwise we may not get the same build as the 0.24.0 release we are downloading for x86.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] smengcl commented on a change in pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#discussion_r814111631
##########
File path: Dockerfile
##########
@@ -14,10 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.17.6-buster
-RUN GO111MODULE=off go get -u github.com/rexray/gocsi/csc
-
-FROM centos:7.9.2009
+FROM golang:1.17.7-buster AS go1
+RUN go install github.com/rexray/gocsi/csc@latest
+
+FROM golang:1.17.7-buster AS go2
+# Compile latest goofys for arm64 if necessary, which doesn't have a released binary
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ if [ ${ARCH} = "aarch64" ]; then \
+ git clone https://github.com/kahing/goofys.git ; \
+ cd goofys ; \
Review comment:
Hey @sodonnel , thanks for the comment.
Actually I tried exactly that a week ago, `v0.24.0` tag wouldn't build on arm64 (in Docker on my M1 Mac). So [some master branch commits](https://github.com/kahing/goofys/compare/v0.24.0...master) probably fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] smengcl commented on a change in pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#discussion_r816088597
##########
File path: Dockerfile
##########
@@ -14,10 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.17.6-buster
-RUN GO111MODULE=off go get -u github.com/rexray/gocsi/csc
-
-FROM centos:7.9.2009
+FROM golang:1.17.7-buster AS go1
+RUN go install github.com/rexray/gocsi/csc@latest
+
+FROM golang:1.17.7-buster AS go2
+# Compile latest goofys for arm64 if necessary, which doesn't have a released binary
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ if [ ${ARCH} = "aarch64" ]; then \
+ git clone https://github.com/kahing/goofys.git ; \
+ cd goofys ; \
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker-runner] sodonnel commented on a change in pull request #11: HDDS-6265. Add arm64 architecture support for ozone-runner docker image
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #11:
URL: https://github.com/apache/ozone-docker-runner/pull/11#discussion_r814150623
##########
File path: Dockerfile
##########
@@ -14,10 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.17.6-buster
-RUN GO111MODULE=off go get -u github.com/rexray/gocsi/csc
-
-FROM centos:7.9.2009
+FROM golang:1.17.7-buster AS go1
+RUN go install github.com/rexray/gocsi/csc@latest
+
+FROM golang:1.17.7-buster AS go2
+# Compile latest goofys for arm64 if necessary, which doesn't have a released binary
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ if [ ${ARCH} = "aarch64" ]; then \
+ git clone https://github.com/kahing/goofys.git ; \
+ cd goofys ; \
Review comment:
OK - makes sense. Pity there doesn't seem to be another release upstream, but for now we will need to use master or a specific commit on master if we want to protect ourselves from future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org