You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by ProjectMoon <gi...@git.apache.org> on 2015/06/04 19:02:53 UTC

[GitHub] cloudstack pull request: Allow PropertiesUtil to read from jar fil...

GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/358

    Allow PropertiesUtil to read from jar files.

    ## Commit Message
    PropertiesUtil has code for reading from jar files, but the
    findConfigFile method will prevent it from ever returning a file in a
    jar on the classpath since it always wants to have a "file:" URL and
    use the File class.
    
    This commit moves the jar file loading attempt from a catch block to
    an else clause, executed if a config file:// URL could not be found.
    
    ## Tests Performed
    Moved API commands from commands.properties to a file in a jar and started up the simulator. Verified that all 479 synced when running the sync command.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-read-properties-from-jars

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #358
    
----
commit ad37446a7b3c241686f6cd3e7af5fc3414fda7dd
Author: jeff <je...@greenqloud.com>
Date:   2015-06-04T16:35:34Z

    Allow PropertiesUtil to read from jar files.
    
    PropertiesUtil has code for reading from jar files, but the
    findConfigFile method will prevent it from ever returning a file in a
    jar on the classpath since it always wants to have a "file:" URL and
    use the File class.
    
    This commit moves the jar file loading attempt from a catch block to
    an else clause, executed if a config file:// URL could not be found.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Allow PropertiesUtil to read from jar fil...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/358


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Allow PropertiesUtil to read from jar fil...

Posted by DaanHoogland <gi...@git.apache.org>.

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/358#issuecomment-109889604
  
    lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---