You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/25 10:57:02 UTC

[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #266: Shutdown the ClientMeterManager during the closing of producer/consumer

aaron-ai opened a new pull request, #266:
URL: https://github.com/apache/rocketmq-clients/pull/266

   Fixes #265 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] aaron-ai merged pull request #266: Bugfix: shutdown ClientMeterManager during the closing of producer/consumer

Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #266:
URL: https://github.com/apache/rocketmq-clients/pull/266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #266: Shutdown ClientMeterManager during the closing of producer/consumer

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #266:
URL: https://github.com/apache/rocketmq-clients/pull/266#issuecomment-1290364050

   # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#266](https://codecov.io/gh/apache/rocketmq-clients/pull/266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55ccbc5) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/3ffaf858114ad8646c44de5d45d0495eb7934259?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ffaf85) will **increase** coverage by `0.09%`.
   > The diff coverage is `75.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #266      +/-   ##
   ============================================
   + Coverage     35.76%   35.86%   +0.09%     
   - Complexity      658      663       +5     
   ============================================
     Files           220      220              
     Lines         11228    11232       +4     
     Branches        275      275              
   ============================================
   + Hits           4016     4028      +12     
   + Misses         6965     6957       -8     
     Partials        247      247              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | java | `62.19% <75.00%> (+0.24%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `53.84% <0.00%> (+0.46%)` | :arrow_up: |
   | [...ache/rocketmq/client/java/metrics/ClientMeter.java](https://codecov.io/gh/apache/rocketmq-clients/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvQ2xpZW50TWV0ZXIuamF2YQ==) | `67.39% <100.00%> (+0.72%)` | :arrow_up: |
   | [...cketmq/client/java/metrics/ClientMeterManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvQ2xpZW50TWV0ZXJNYW5hZ2VyLmphdmE=) | `71.42% <100.00%> (+0.69%)` | :arrow_up: |
   | [...e/rocketmq/client/java/impl/ClientManagerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlckltcGwuamF2YQ==) | `82.26% <0.00%> (+3.44%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org