You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/03/13 20:10:03 UTC
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #452: Revised Data Editor Integration
Shanedell commented on code in PR #452:
URL: https://github.com/apache/daffodil-vscode/pull/452#discussion_r1134563787
##########
src/omega_edit/client.ts:
##########
@@ -41,217 +37,174 @@ export function getOmegaEditPackageVersion(filePath: fs.PathLike) {
]
}
-async function cleanupViewportSession(
- sessionId: string,
- viewportIds: Array<string>
-) {
- viewportIds.forEach(async (vid) => {
- await omegaEditViewport.destroyViewport(vid)
- })
- await omegaEditSession.destroySession(sessionId)
-}
-
-async function commonOmegaEdit(
- ctx: vscode.ExtensionContext,
- startServer: boolean,
- omegaEditPackageVersion: string,
- port: number
-) {
- if (!serverRunning && startServer) {
- ;[serverTerminal, serverRunning] = await startOmegaEditServer(
- ctx,
- rootPath,
- omegaEditPackageVersion,
- port
- )
- }
+function getServerPidFile() {
+ return path.join(appDataPath, `serv-${serverPort}.pid`)
}
-async function getOmegaEditPort(
- port: number | undefined = undefined
-): Promise<number> {
+async function getOmegaEditPort(port: number | undefined = undefined) {
if (!port) {
+ const defaultServerPort = vscode.workspace
+ .getConfiguration('dataEditor')
+ .get<number>('defaultServerPort', serverPort)
const portEntered = await vscode.window.showInputBox({
prompt: 'Enter port number to run omega-edit server on',
- value: '9000',
+ value: defaultServerPort.toString(),
})
if (portEntered) {
- port = +portEntered
+ serverPort = parseInt(portEntered)
} else {
+ serverPort = 0
throw Error('Bad port entered')
}
+ } else {
+ serverPort = port
+ }
+}
+
+function setupLogging() {
+ const config = vscode.workspace.getConfiguration('dataEditor')
+ const logFile = config
+ .get<string>('logFile', '${workspaceFolder}/dataEditor-${serverPort}.log')
+ ?.replace('${workspaceFolder}', appDataPath)
+ .replace('${serverPort}', serverPort.toString())
+ const logLevel =
+ process.env.OMEGA_EDIT_CLIENT_LOG_LEVEL ||
+ config.get<string>('logLevel', 'info')
+ fs.writeFileSync('/tmp/test75.txt', 'HERE 1')
Review Comment:
Remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org